Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the upload path to respect a device/display capability flag (supports_zip) so compressed uploads are only attempted when the connected device reports ZIP transmission support.
Changes:
- Gate compressed upload protocol selection in
OpenDisplayDevice.upload_image()andupload_prepared_image()based onDisplayConfig.supports_zip. - Add unit tests for
DisplayConfig.supports_zipderived from thetransmission_modesbitfield. - Add unit tests ensuring upload methods enable/disable compression based on device config and size limits.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/unit/test_models_config.py | Adds coverage for DisplayConfig.supports_zip derived from transmission_modes. |
| tests/unit/test_device_upload_compression.py | New tests asserting upload methods respect device ZIP support (and size/flags). |
| src/opendisplay/device.py | Uses config-reported ZIP support to decide whether to use compressed upload protocol. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.